Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make revcomp variation yield processor when spin-waiting #26701

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

bradcray
Copy link
Member

The valgrind executions of this test have been timing out with some frequency lately after some system upgrades in the spin version of the algorithm. I think that, to be correct, the spin versions need to be yielding the processor, and that historically we've "gotten away" with not doing so without penalty or overhead. Here, I'm updating the test to include the yield in hopes that it helps with the timeouts, and also to see what impact it has on the performance of the test.

The valgrind executions of this test have been timing out with some
frequency lately after some system upgrades in the spin version of the
algorithm.  I think that, to be correct, the spin versions should be
yielding the processor, so here I'm updating the test to do just that
in hopes that it helps.

---
Signed-off-by: Brad Chamberlain <[email protected]>
@bradcray bradcray merged commit 6fdb5db into chapel-lang:main Feb 12, 2025
9 checks passed
@bradcray bradcray deleted the make-spin-revcomp-yield branch February 12, 2025 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant