EvseV2G: minor fixes, simplify logging #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Moritz Barsnick <[email protected]>
While not converting the module to standard EVerest EVLOG_*, this significantly simplifies the dlog() cruft to the most necessary bits. As a side effect, the annoying empty lines on stdout logging are removed. This also converts the macro to a function. Also drop obviously obsolete trailing newlines from dlog() calls. Signed-off-by: Moritz Barsnick <[email protected]>
|
Definitely the right direction. I suggest taking the next step straight away: get rid of dlog completely. |
Okay, let's do it. That will involve using the fmt library, but that's a good thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT - DO NOT MERGE
I just want an internal review, before I put up a pull request against upstream.
Describe your changes
The EvseV2G module still uses our old truffle
dlog()infrastructure. This has become overkill, as its particular features are unused (file names and line numbers, changing log level at runtime). Furthermore, string concatenations and timestamp calculations are still being done though never used!This PR strips everything which is not used from the log functions, and converts
dlog()from a macro to a function.dlog()is now a simple converter from C-printf-style logging toEVLOG_*streams.Also, some very minor logic simplifications are made, without impact on the compiled code.
Issue ticket number and link
Checklist before requesting a review