Allow laminas/laminas-diactoros v3 #21
Conversation
| }, | ||
| "require-dev": { | ||
| "samdark/yii2-psr-log-target": "^1.0", | ||
| "monolog/monolog": "~2.1.0", | ||
| "squizlabs/php_codesniffer": "^3.2", | ||
| "phpunit/phpunit": "^9.0", | ||
| "spiral/roadrunner": "^2.5" | ||
| "spiral/roadrunner": "^2.5", | ||
| "yidas/yii2-bower-asset": "2.0.13.1" |
There was a problem hiding this comment.
Thanks for the PR! This dependency yidas/yii2-bower-asset I don't believe needs to be added. If you can remove it and update the composer.lock file I'd be happy to merge this in. I'd prefer not to lock this and let Yii2 automatically pull it in as needed.
There was a problem hiding this comment.
It was there before me, so I decided that you actually needed it and moved to the dev section. Should I still remove it? I believe without it you wouldn't be able to install the Yii2 framework since it requires some bower assets.
There was a problem hiding this comment.
@charlesportwoodii, kind ping :)
There was a problem hiding this comment.
@erickskrauch, @charlesportwoodii, I think, we should use asset-packagist (bower-asset) approach here, as it is currently the main method for Yii2 applications. Otherwise, for now, this bridge will prevent asset-packagist from installing packages to vendor/bower-asset directory and use yidas/yii2-bower-asset/bower directory instead.
See for more information: https://www.yiiframework.com/doc/guide/2.0/en/structure-assets#bower-npm-assets
charlesportwoodii
added
bug
While updating the dependencies, I also found a bug in the implementation inside Psr7ResponseTrait. I know it's not good to mix multiple edits in one PR, but I thought this fix might be part of an adaptation to laminas/laminas-diactoros v3 support :)