Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): update examples #1318

Merged
merged 10 commits into from
Feb 11, 2025
Merged

feat(v2): update examples #1318

merged 10 commits into from
Feb 11, 2025

Conversation

caarlos0
Copy link
Member

supercedes #1304

Signed-off-by: Carlos Alexandro Becker <[email protected]>
@meowgorithm
Copy link
Member

The tests are failing here. iirc, @aymanbagabas you changed the way clear screen works, correct? if so, could you update the tests here?

@aymanbagabas
Copy link
Member

The tests are failing here. iirc, @aymanbagabas you changed the way clear screen works, correct? if so, could you update the tests here?

Correct, fwiw, I'm making a few changes to the renderer that will affect the tests, we will need to update the tests again after that.

@aymanbagabas
Copy link
Member

I've updated the testdata and golden files in v2-exp to use the latest renderer, which includes a behavioral breaking change. Now, on program exit, the renderer will always move the cursor to the beginning of the next line of the screen, scrolling the terminal if necessary. This means examples and programs that include a trailing newline in their View() won't need to do so anymore.

@caarlos0
Copy link
Member Author

caarlos0 commented Feb 11, 2025

@aymanbagabas windows still failing though, looking into it

@caarlos0 caarlos0 merged commit 11e96ff into v2-exp Feb 11, 2025
44 checks passed
@caarlos0 caarlos0 deleted the v2-example-update branch February 11, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants