-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v2): update examples #1318
Conversation
Signed-off-by: Carlos Alexandro Becker <[email protected]>
The tests are failing here. iirc, @aymanbagabas you changed the way clear screen works, correct? if so, could you update the tests here? |
Correct, fwiw, I'm making a few changes to the renderer that will affect the tests, we will need to update the tests again after that. |
I've updated the testdata and golden files in |
Signed-off-by: Carlos Alexandro Becker <[email protected]>
@aymanbagabas windows still failing though, looking into it |
Signed-off-by: Carlos Alexandro Becker <[email protected]>
This reverts commit b553f65.
supercedes #1304