feat: support adaptive colors extension #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will choose the color based on the `HasLightBackground` value of the writer. This is useful for supporting the adaptive colors extension in the terminal. Extension specs: SGR already defines 5 and 2 for 16 and 24-bit colors to be used with the 38, 48, and 58 parameters. This extension adds support for adaptive colors, which will choose the color based on the HasLightBackground value of the writer. The 4 parameter is used to specify light-dark 24-bit colors. ``` printf '\x1b[38;4;255;0;0;0;255;0mHello, world!\x1b[0m\n' ``` Here the first three values are the light color and the last three values are the dark color. The 10 parameter is used to specify light-dark 256 colors. ``` printf '\x1b[38;10;255;0mHello, world!\x1b[0m\n' ```
bashbunni
reviewed
Oct 22, 2024
| @@ -170,6 +174,36 @@ func readColor(idxp *int, params []int) (c ansi.Color) { | |||
| } | |||
| c = ansi.ExtendedColor(ansi.Param(params[i+2])) //nolint:gosec | |||
| *idxp += 2 | |||
| case 4: // lightDark(RGB) | |||
There was a problem hiding this comment.
Maybe we should use a const value to get rid of magic numbers?
|
Nice! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will choose the color based on the
HasLightBackgroundvalue of the writer. This is useful for supporting the adaptive colors extension in the terminal.Extension specs:
SGR already defines 5 and 2 for 16 and 24-bit colors to be used with the 38, 48, and 58 parameters. This extension adds support for adaptive colors, which will choose the color based on the HasLightBackground value of the writer.
The 4 parameter is used to specify light-dark 24-bit colors.
Here the first three values are the light color and the last three values are the dark color.
The 10 parameter is used to specify light-dark 256 colors.