fix(accessibility): stop scanning on EOF from stdin #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aybabtme
force-pushed
the
stop-scanning-on-eof
branch
from
f869ade
to
947aa08
Compare
aybabtme
changed the title
caarlos0
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user send EOF to stdin (Ctrl-C) in the terminal while in accessibility mode, the program gets stuck in a loop printing errors about invalid input:
This change isn't ideal (it'd be better to somehow bubble up an error that stops execution) but it's better than getting the process stuck in a loop. An alternative that doesn't change the signature would be to panic, or
os.Exitor something else. Happy with whatever.