Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid error on empty repo collabs #466

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

aymanbagabas
Copy link
Member

Propagate a more informative error when adding an existing collaborator. Ignore webhooks default branch git reference not found errors because the repo won't have a default branch when it's empty.

Fixes: #464

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (b06b555) 51.96% compared to head (7112a65) 52.02%.

Files Patch % Lines
pkg/webhook/repository.go 25.00% 2 Missing and 1 partial ⚠️
pkg/webhook/webhook.go 70.00% 2 Missing and 1 partial ⚠️
pkg/webhook/push.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #466      +/-   ##
==========================================
+ Coverage   51.96%   52.02%   +0.06%     
==========================================
  Files         157      157              
  Lines       13454    13464      +10     
==========================================
+ Hits         6991     7005      +14     
+ Misses       5891     5885       -6     
- Partials      572      574       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Propagate a more informative error when adding an existing collaborator.
Ignore webhooks default branch git reference not found errors because
the repo won't have a default branch when it's empty.

Fixes: #464
@aymanbagabas aymanbagabas merged commit 047b6a7 into main Feb 5, 2024
11 checks passed
@aymanbagabas aymanbagabas deleted the readd-collab branch February 5, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't add collaborator to empty repo
1 participant