Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repo URL width calculation. #637

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

dominicdoty
Copy link
Contributor

@dominicdoty dominicdoty commented Jan 17, 2025

Previous code only used description width to calculate remaining space.

At that point the description has already been merged into the header so the header can be used to calculate remaining width correctly.

Fixes #521

E.G.

Before:
Screenshot from 2025-01-17 13-22-20

After:
Screenshot from 2025-01-17 13-21-06

Previous code only used description width to calculate remaining space.
At that point the desc has already been merged into the header so the header can be used to calculate remaining width correctly.
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 51.70%. Comparing base (b06b555) to head (e0e840f).
Report is 111 commits behind head on main.

Files with missing lines Patch % Lines
pkg/ui/pages/repo/repo.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #637      +/-   ##
==========================================
- Coverage   51.96%   51.70%   -0.26%     
==========================================
  Files         157      159       +2     
  Lines       13454    13552      +98     
==========================================
+ Hits         6991     7007      +16     
- Misses       5891     5973      +82     
  Partials      572      572              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@aymanbagabas aymanbagabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dominicdoty !

@aymanbagabas aymanbagabas merged commit eb15371 into charmbracelet:main Jan 22, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header truncates clone command at 36 characters
2 participants