feat: add the calculate_rs function to slurmutils
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NucciTheBoss
added
the
Type: Enhancement
dsloanm
approved these changes
Jan 9, 2025
`calculate_rs` can only calculate the ranges and strides on an iterable which contains integers. The function uses subtraction to calculate the ranges which is not a valid operation on strings even though the built-in `sorted` function can sort integers typed as strings (e.g "1", "2", "3", etc.) in ascending order. Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
`calculate_rs` must mention that elements should be unique, otherwise the ranges and strides calculation will fail. Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
NucciTheBoss
force-pushed
the
nuccitheboss/feat/add-calculate-rs
branch
from
c66dfb6 to
2c1abc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds @dsloanm's mega-based
calculate_rsmethod to slurmutils so that it can be easily consumed by other charms. I copied it into theutilsmodule, but it can be imported through the top-level module:I also added some unit tests and documentation for
calculate_rsso that we have some examples of how it can be used to calculate device file and node name ranges.