Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Extend model descriptors #8

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Conversation

NucciTheBoss
Copy link
Member

Adds deleters and setters for the data pockets on SlurmConfig. This makes it easier to perform bulk operations on the SlurmConfig object as now you can set an entire new partition, nodes, etc or you can blow out the existing node set or down node configuration.

Closes #7

If a data model had a primary key, its value would not be present in its printed string representation. Now there is a simple conditional that checks for the presence of a primary key. If there is one, it modifies the string output accordingly.

Signed-off-by: Jason C. Nucciarone <[email protected]>
Enhance the functionality of the `SlurmConfig` data model by letting developers directly access the data pockets for nodes, partitions, etc. Makes it much easier to perform bulk operations on the `SlurmConfig` object.

Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
@NucciTheBoss NucciTheBoss added Priority: Critical This should be fixed RIGHT NOW. Should be used only for issues that affect everyone. Type: Enhancement Proposes a new feature to be added to the project. labels Feb 8, 2024
@NucciTheBoss NucciTheBoss self-assigned this Feb 8, 2024
@NucciTheBoss NucciTheBoss merged commit f860fe4 into main Feb 8, 2024
4 checks passed
@NucciTheBoss NucciTheBoss deleted the extend-model-descriptors branch February 20, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Critical This should be fixed RIGHT NOW. Should be used only for issues that affect everyone. Type: Enhancement Proposes a new feature to be added to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance descriptors for data pockets in slurmutils.models.slurm.SlurmConfig
1 participant