feat: check constructs against account default runtime if not given [sc-22843] #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CLI had a hardcoded default runtime value of 2024.02 which became the effective value if no runtime was set at check or project level. Now, the account's default runtime is used instead. Additionally, if the account's default runtime is used, then we leave `runtimeId` undefined when synthesizing resources. This allows the user to have their checks always use the current account default runtime if they wish. If they do not wish to have such behavior, they should set a default runtime at project level as usual.
sorccu
force-pushed
the
simokinnunen/sc-22843/check-account-runtime-if-check-runtime-is
branch
from
8745c9a to
302aa8b
Compare
maxigimenez
reviewed
Jan 13, 2025
sorccu
deleted the
simokinnunen/sc-22843/check-account-runtime-if-check-runtime-is
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLI had a hardcoded default runtime value of
2024.02, which became the effective value if no runtime was set at check or project level. Now, the account's default runtime is used instead. Additionally, if the account's default runtime is used, then we leaveruntimeIdundefined when synthesizing resources. This allows the user to have their checks always use the current account default runtime if they wish. If they do not wish to have such behavior, they should set a default runtime at project level as usual.Technically speaking this is a potentially breaking change if a user has something other than
2024.02set as their default account runtime, and have never set a runtime at project or check level. When they next deploy their checks (or runcheckly test), a different runtime will be used. However, this kind of usage should be rare, and the user may simply change their default account runtime or define the runtime in the CLI project to restore the previous runtime, if needed.I hereby confirm that I followed the code guidelines found at engineering guidelines
Affected Components
Notes for the Reviewer
New Dependency Submission