feat: support subpaths of supported dependencies (e.g. node:fs/promises) [sc-22943]
#1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorccu
force-pushed
the
simokinnunen/sc-22633/support-node-prefix-for-built-in-node-dependencies
branch
from
f2b5c4d to
9bbfcad
Compare
Base automatically changed from
simokinnunen/sc-22633/support-node-prefix-for-built-in-node-dependencies
to
main
January 20, 2025 06:32
sorccu
force-pushed
the
simokinnunen/sc-22943/support-subpaths-of-supported-dependencies
branch
from
1a6865e to
a3106e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible (or rather, allowed) to import subpaths from a supported dependency, such as
node:fs/promiseseven though we only listnode:fsas a supported module. It also supports cases where a dependency usesexportsinpackage.jsonto expose subpaths of the module, and legacy usage where you don't specify anyexportsbut access subpaths anyway. One very basic example beingcheckly/constructs. Note that these subpaths are not currently allowed by the runner due to its very basic allow-list implementation.I hereby confirm that I followed the code guidelines found at engineering guidelines
Affected Components
Notes for the Reviewer
New Dependency Submission