feat(parallel): support runParallel in checks and groups [sc-18210]
#900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #18210: Add |
…-checks-construct
|
The currently failing tests are due to them using an outdated version of the BE, right? (outdated meaning they don't have the changes in the BE PR that is). Because otherwise, LGTM 👍 Worked locally with both PRs checked out |
Yes exactly, once the schema update is deployed, the tests here should pass 🤞 |
maxigimenez
requested changes
Dec 14, 2023
…-checks-construct
|
🎉 Experimental release successfully published on npm |
maxigimenez
approved these changes
Dec 15, 2023
clample
deleted the
manelfourati/sc-18210/add-runparallel-to-cli-checks-construct
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby confirm that I followed the code guidelines found at engineering guidelines
Affected Components
Notes for the Reviewer
Add
runParallelto check and group constructs to allow simultaneous check run scheduling on multi-locations.If set to false, the check runs will be scheduled in the different locations in a round-robin fashion.
Requires this BE PR for testing.