Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): Bump typescript from 4.9.4 to 5.3.3 #903

Merged
merged 4 commits into from
Jan 22, 2024
Merged

chore(deps-dev): Bump typescript from 4.9.4 to 5.3.3 #903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f803adb
chore(deps-dev): Bump typescript from 4.9.4 to 5.3.3
dependabot[bot] Dec 7, 2023
bbdd1fd
Merge branch 'main' into dependabot/npm_and_yarn/typescript-5.3.3
ferrandiaz Jan 19, 2024
5c35e05
fix: bump estree version so we can use ts 5.3.3
ferrandiaz Jan 22, 2024
0f34b02
Merge branch 'main' into dependabot/npm_and_yarn/typescript-5.3.3
ferrandiaz Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
173 changes: 77 additions & 96 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
"@oclif/plugin-not-found": "2.3.23",
"@oclif/plugin-plugins": "4.1.12",
"@oclif/plugin-warn-if-update-available": "2.0.24",
"@typescript-eslint/typescript-estree": "6.7.2",
"@typescript-eslint/typescript-estree": "6.19.0",
Copy link
Contributor

@clample clample Jan 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to be a bit careful with this one. Each @typescript-eslint/typescript-estree" only supports a specific range of TypeScript versions. This can end up being a breaking change for users. (#848)

I think we can make this change, but if the supported TS versions change it could be good to mention it in the release notes. The supported TypeScript versions are here: https://github.com/typescript-eslint/typescript-eslint/blob/920f909debc3eb394f5aef4e36568bdf6641e304/packages/typescript-estree/src/parseSettings/warnAboutTSVersion.ts#L9.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6.7.2 only supports up to 5.3 (so 5.3.3 of TS is not supported) 6.19.0 supports up to 5.4 and both of them support from 4.3.5 onwards
@tnolet @umutuzgur WDYT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ferrandiaz this is above my paygrade. Please make the decision based on what's good for the users.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both support 4.3.5 onwards, so we don't risk breaking anyones setup. I think we can just merge it 👍

"acorn": "8.8.1",
"acorn-walk": "8.2.0",
"async-mqtt": "2.6.3",
Expand Down Expand Up @@ -116,7 +116,7 @@
"simple-git-hooks": "2.8.1",
"ts-jest": "29.0.3",
"ts-node": "10.9.1",
"typescript": "4.9.4"
"typescript": "5.3.3"
},
"jest": {
"testTimeout": 30000,
Expand Down
2 changes: 1 addition & 1 deletion packages/create-cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"rimraf": "5.0.1",
"ts-jest": "29.0.3",
"ts-node": "10.9.1",
"typescript": "4.9.4"
"typescript": "5.3.3"
},
"jest": {
"projects": [
Expand Down
Loading