-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add alert escalation policy as part of the check/config #922
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
// eslint-disable-next-line no-restricted-syntax | ||
enum AlertEscalationType { | ||
RUN = 'RUN_BASED', | ||
TIME = 'TIME_BASED' | ||
} | ||
|
||
export type Reminders = { | ||
amount?: number, | ||
interval?: number | ||
} | ||
|
||
export interface AlertEscalation { | ||
escalationType?: AlertEscalationType, | ||
runBasedEscalation?: { | ||
failedRunThreshold?: number | ||
}, | ||
timeBasedEscalation?: { | ||
minutesFailingThreshold?: number | ||
}, | ||
reminders?: Reminders | ||
} | ||
|
||
export type AlertEscalationOptions = Pick<AlertEscalation, 'runBasedEscalation' | 'timeBasedEscalation' | 'reminders'> | ||
|
||
export class AlertEscalationBuilder { | ||
private static DEFAULT_RUN_BASED_ESCALATION = { failedRunThreshold: 1 } | ||
private static DEFAULT_TIME_BASED_ESCALATION = { minutesFailingThreshold: 5 } | ||
private static DEFAULT_REMINDERS = { amount: 0, interval: 5 } | ||
|
||
static runBasedEscalation (failedRunThreshold: number, reminders?: Reminders) { | ||
const options: AlertEscalationOptions = { | ||
runBasedEscalation: { | ||
failedRunThreshold, | ||
}, | ||
reminders, | ||
} | ||
return this.alertEscalation(AlertEscalationType.RUN, options) | ||
} | ||
|
||
static timeBasedEscalation (minutesFailingThreshold: number, reminders?: Reminders) { | ||
const options: AlertEscalationOptions = { | ||
timeBasedEscalation: { | ||
minutesFailingThreshold, | ||
}, | ||
reminders, | ||
} | ||
return this.alertEscalation(AlertEscalationType.TIME, options) | ||
} | ||
|
||
private static alertEscalation (escalationType: AlertEscalationType, | ||
options: AlertEscalationOptions): AlertEscalation { | ||
return { | ||
escalationType, | ||
runBasedEscalation: options.runBasedEscalation ?? this.DEFAULT_RUN_BASED_ESCALATION, | ||
timeBasedEscalation: options.timeBasedEscalation ?? this.DEFAULT_TIME_BASED_ESCALATION, | ||
reminders: options.reminders ?? this.DEFAULT_REMINDERS, | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tnolet what do you think about this? Basically we set
useGlobalAlertSettings
totrue
ifalertSettings
doesn't exist and vice versaThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@umutuzgur @ferrandiaz hmmmm, feels a bit iffy / hidden magic. Not sure if we have a great alternative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just my 2 cents, but I think it's nice. As a user, I think that it would be confusing if I passed
alertSettings
, but they weren't actually applied because I need to also explicitly setuseGlobalAlertSettings
. I'm not sure there's a case in the CLI were I would passalertSettings
but not want it to actually be used.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clample yes, I agree. This seems to be the best UX. @umutuzgur @ferrandiaz let's go with this.