Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: increase test session timeout #954

Merged
merged 1 commit into from
Jul 19, 2024
Merged

feat: increase test session timeout #954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/cli/src/commands/trigger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { loadChecklyConfig } from '../services/checkly-config-loader'
import { splitConfigFilePath, getEnvs, getGitInformation, getCiInformation } from '../services/util'
import type { Region } from '..'
import TriggerRunner, { NoMatchingChecksError } from '../services/trigger-runner'
import { RunLocation, Events, PrivateRunLocation, CheckRunId } from '../services/abstract-check-runner'
import { RunLocation, Events, PrivateRunLocation, CheckRunId, DEFAULT_CHECK_RUN_TIMEOUT_SECONDS } from '../services/abstract-check-runner'
import config from '../services/config'
import { createReporters, ReporterType } from '../reporters/reporter'
import { TestResultsShortLinks } from '../rest/test-sessions'
Expand Down Expand Up @@ -42,7 +42,7 @@ export default class Trigger extends AuthCommand {
description: 'The Checkly CLI config filename.',
}),
timeout: Flags.integer({
default: 240,
default: DEFAULT_CHECK_RUN_TIMEOUT_SECONDS,
description: 'A timeout (in seconds) to wait for checks to complete.',
}),
verbose: Flags.boolean({
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/services/abstract-check-runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export type RunLocation = PublicRunLocation | PrivateRunLocation

export type CheckRunId = string

export const DEFAULT_CHECK_RUN_TIMEOUT_SECONDS = 300
export const DEFAULT_CHECK_RUN_TIMEOUT_SECONDS = 600

const DEFAULT_SCHEDULING_DELAY_EXCEEDED_MS = 20000

Expand Down
Loading