Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add BillingAddress, Phone and AccountHolder to payment source with ID #146

Merged
merged 1 commit into from
Feb 5, 2025
Merged

add BillingAddress, Phone and AccountHolder to payment source with ID #146

merged 1 commit into from
Feb 5, 2025

Conversation

rockwelln
Copy link
Contributor

@rockwelln rockwelln marked this pull request as ready for review January 15, 2025 15:28
@armando-rodriguez-cko
Copy link
Contributor

Thank you @rockwelln

@rockwelln
Copy link
Contributor Author

@armando-rodriguez-cko Is there anything I can do to move forward?

@rockwelln
Copy link
Contributor Author

could you please consider this change in a future version?
thank you

armando-rodriguez-cko
armando-rodriguez-cko approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@armando-rodriguez-cko armando-rodriguez-cko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

payments/nas/sources/sources.go Show resolved Hide resolved
@armando-rodriguez-cko armando-rodriguez-cko merged commit c1d8d26 into checkout:master Feb 5, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armando-rodriguez-cko armando-rodriguez-cko armando-rodriguez-cko approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rockwelln @armando-rodriguez-cko