Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS and PG password encryption and decryption during fresh deployment #8755

Closed

Conversation

rensycthomas
Copy link
Collaborator

…ployment

🔩 Description: What code changed, and why?

  • Encodes os and pg passwords to base 64 format
  • Decodes os and pg passwords to plain text before provisioning
  • Handles fresh deployment scenario for customer managed and aws managed databases

⛓️ Related Resources

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Copy link

netlify bot commented Jan 24, 2025

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit c1889b1
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/679a36b3176a0700093b7d00

@rensycthomas rensycthomas force-pushed the rt/CHEF-16880_encode_decode_os_pg_pwd_fresh_deploy branch from 43d7dd5 to 98477ac Compare January 27, 2025 12:00
@rensycthomas rensycthomas force-pushed the rt/CHEF-16880_encode_decode_os_pg_pwd_fresh_deploy branch from c27abfd to b12c47a Compare January 29, 2025 09:41

Quality Gate failed Quality Gate failed

Failed conditions
2 New issues
71.2% Coverage on New Code (required ≥ 80%)
13.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant