Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use npm registry instead of retrieving project through ssh #58

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rimiti
Copy link

@rimiti rimiti commented Apr 30, 2024

Hi @chengsokdara, 👋

Using SSH for getting package is a really bad practice for security and regression reason.
Code present on #master branch seems to be the code deployed on NPM.

An another example of side effect to not use NPM:
When we install your (nice) package, it's mandatory into our Dockerfile image to add SSH a the Gihub Public git...

Have a nice day.
Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant