Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 isort shouldn't sort the migration versions files. #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nymann
Copy link
Contributor

@nymann nymann commented Jul 26, 2020

The sys append should be before the import of migrations
if you read the comments it makes sense too
but it has been autosorted by something

@nymann nymann requested a review from LukasZahradnik July 26, 2020 22:48
@codecov-commenter
Copy link

Codecov Report

Merging #13 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #13   +/-   ##
=======================================
  Coverage   91.62%   91.62%           
=======================================
  Files          12       12           
  Lines         179      179           
  Branches        4        4           
=======================================
  Hits          164      164           
  Misses         13       13           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb03d34...55bb560. Read the comment docs.

@nymann
Copy link
Contributor Author

nymann commented Jul 26, 2020

We need to fix the underlying problem before we can merge (autosort).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants