[#690] Vendor randomly nose extension. Remove nose dependency. More ruff fixes. #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #702 +/- ##
==========================================
- Coverage 79.05% 79.02% -0.03%
==========================================
Files 47 48 +1
Lines 7738 7811 +73
Branches 1151 1163 +12
==========================================
+ Hits 6117 6173 +56
- Misses 1355 1363 +8
- Partials 266 275 +9 see 18 files with indirect coverage changes
|
|
needs-review |
|
Thanks for the review. I am trying to migrate to ruff ... our linting tools are old... and I don't have time to keep them up to date. Ruff looks like the future ... btw, it a tool for python written in rust. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Fixes #690
This starts as updating chevah_compat to no longer depend on nose.
I then use it to update ruff...and then run more fixes with ruff.
Changes
node_Randomly project is no longer maintained...so vendor it.
Update ruff and fix more checks raised by ruff.
How to try and test the changes
reviewers: @dumol
More of a FYI. No need to review the code.
The nose_Randomly was copied from upstream ... link the our source file.
The other changes were mostly automatically done by
ruff... or by the new custom FIXME to TODO migration tool.This is needed to support chevah/server py3.12 migratin
This also moves from our
# FIXME:markers to more "standards" TODO markers. They are explaned here.Our
FIXMEmarkers were selected more than 10 years ago...and today the standard markers are TODOs and not fixmes. Also, the issue ID or link is sent on the next line.