Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): printable non A-Z chars should output symbols in pinyin #593

Merged
merged 2 commits into from
Jul 6, 2024

Conversation

kanru
Copy link
Member

@kanru kanru commented Jul 6, 2024

Fixes #592

@kanru kanru added this to the v0.8.5 milestone Jul 6, 2024
Copy link

codecov bot commented Jul 6, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 8 lines in your changes missing coverage. Please review.

Project coverage is 88.74%. Comparing base (38cc8ae) to head (bfb814c).

Files Patch % Lines
src/editor/mod.rs 50.00% 8 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           release/0.8.x     #593      +/-   ##
=================================================
- Coverage          88.77%   88.74%   -0.03%     
=================================================
  Files                 59       59              
  Lines              13651    13677      +26     
=================================================
+ Hits               12119    12138      +19     
- Misses              1532     1539       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kanru kanru merged commit d6d5221 into release/0.8.x Jul 6, 2024
17 of 18 checks passed
@kanru kanru deleted the issue592 branch July 6, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant