Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] broken links #246

Merged
merged 42 commits into from
Dec 19, 2023
Merged

[Fix] broken links #246

merged 42 commits into from
Dec 19, 2023

Conversation

BramVerniest
Copy link
Collaborator

No description provided.

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-sky-012b9bc03-246.westeurope.1.azurestaticapps.net

@BramVerniest
Copy link
Collaborator Author

@amarquezChili Could you approve this PR?

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-sky-012b9bc03-246.westeurope.1.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-sky-012b9bc03-246.westeurope.1.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-sky-012b9bc03-246.westeurope.1.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-sky-012b9bc03-246.westeurope.1.azurestaticapps.net

@BramVerniest
Copy link
Collaborator Author

BramVerniest commented Dec 11, 2023

Only 1 broken link report left. But it's a mention of a redirect URI for the integration. It should not be treated as a "link".
Can we configure linkecker to avoid links that are not marked as links in markdown?
@amarquezChili Could you approve this PR, then we can fix the exception later.

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-sky-012b9bc03-246.westeurope.1.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-sky-012b9bc03-246.westeurope.1.azurestaticapps.net

Copy link
Contributor

@amarquezChili amarquezChili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, No broken links

@BramVerniest BramVerniest merged commit 3beef8c into main Dec 19, 2023
3 checks passed
@BramVerniest BramVerniest deleted the fix/broken-links branch December 19, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants