Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#2169) Pass choria federations to external discovery agent #2170

Merged
merged 1 commit into from
May 21, 2024
Merged

(#2169) Pass choria federations to external discovery agent #2170

merged 1 commit into from
May 21, 2024

Conversation

vjanelle
Copy link
Member

@vjanelle vjanelle commented May 2, 2024

No description provided.

@vjanelle vjanelle marked this pull request as draft May 2, 2024 22:53
@vjanelle vjanelle requested a review from ripienaar May 2, 2024 22:54
vjanelle
vjanelle commented May 2, 2024
View reviewed changes
config/config.go Outdated Show resolved Hide resolved
vjanelle
vjanelle commented May 2, 2024
View reviewed changes
inter/imocks/util.go Outdated Show resolved Hide resolved
ripienaar
ripienaar reviewed May 3, 2024
View reviewed changes
config/config.go Outdated Show resolved Hide resolved
providers/discovery/external/external.go Show resolved Hide resolved
providers/discovery/external/external_test.go Outdated Show resolved Hide resolved
ripienaar
ripienaar reviewed May 13, 2024
View reviewed changes
Copy link
Member

@ripienaar ripienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty good, minor edit

providers/discovery/external/options.go Outdated Show resolved Hide resolved
@vjanelle vjanelle force-pushed the federation_external_agents branch from 980b28e to 69c8740 Compare May 16, 2024 19:54
vjanelle
vjanelle commented May 16, 2024
View reviewed changes
cmd/cmd.go Outdated Show resolved Hide resolved
@vjanelle vjanelle force-pushed the federation_external_agents branch 2 times, most recently from 332607d to 6700756 Compare May 17, 2024 20:56
ripienaar
ripienaar requested changes May 18, 2024
View reviewed changes
Copy link
Member

@ripienaar ripienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes otherwise its good

cmd/discover.go Outdated Show resolved Hide resolved
cmd/req.go Outdated Show resolved Hide resolved
@vjanelle vjanelle force-pushed the federation_external_agents branch 2 times, most recently from dbf557c to 9d93ebe Compare May 18, 2024 23:27
@vjanelle
Copy link
Member Author

Added the flag to the ping command as well, I use that for making sure connectivity is ok

@vjanelle vjanelle requested a review from ripienaar May 18, 2024 23:34
@vjanelle vjanelle marked this pull request as ready for review May 18, 2024 23:35
ripienaar
ripienaar approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@ripienaar ripienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vjanelle vjanelle force-pushed the federation_external_agents branch from 9d93ebe to 039f1bd Compare May 21, 2024 00:45
@vjanelle vjanelle merged commit 4ca21a3 into choria-io:main May 21, 2024
4 of 6 checks passed
@vjanelle vjanelle deleted the federation_external_agents branch May 21, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripienaar ripienaar ripienaar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vjanelle @ripienaar