feat: add new endpoints to add organizations to an existing user #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OCD-4721
OCD-4721
kekey1
approved these changes
Nov 7, 2024
| @@ -92,6 +96,24 @@ public UserManagementController(UserManager userManager, InvitationManager invit | |||
| this.authorizationLengthInDays = authorizationLengthInDays; | |||
| } | |||
|
|
|||
| @Operation(summary = "Update the currently logged in user with an additional organization.", | |||
| description = "Gives the user permission on the object in the invitation (usually an additional ACB or Developer)." | |||
There was a problem hiding this comment.
I think this documentation is copied from the CHPL-login workflow methods. The line about which endpoints to call in which order is not right for the Cognito methods. Can you check the other Cognito auth methods as well? They are not currently in the diff but it looks like they might have the same documentation.
| @@ -181,9 +186,28 @@ public User getUserInfo(UUID cognitoId) throws UserRetrievalException { | |||
| } | |||
| } | |||
| return null; | |||
| } | |||
|
|
|||
| public User getUserByPassingCognitoUserAttributeCache(String accessToken) throws UserRetrievalException { | |||
There was a problem hiding this comment.
When I first read this method name I thought it was two words "by passing" but I think it's meant as one word "bypassing" - can you change the camelcase to make this clear? getUserBypassingCognitoUserAttributeCache, or maybe even simpler getUserNoCache?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCD-4721