OCD-4705: Fixes related to uploading and confirming via file #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andlar
previously approved these changes
Nov 5, 2024
tmy1313
previously approved these changes
Nov 6, 2024
andlar
previously approved these changes
Nov 13, 2024
This was deleted (by accident??) in OCD-4660 and we really need it! A whole host of issues appear when it is not present. [#OCD-4705]
andlar
previously approved these changes
Nov 14, 2024
When reviewing the checklist of things that should happen when a9 gets removed, I realized that certain criteria are considered "editable" - that is if they have been removed less than 1 year ago. I was including ALL criteria in the listing CSV File but I think that might be confusing for users actually because they would see some "original" criteria that actually could not be added anyway. This commit changes the criteria included in the download file - only those that are 1) attested or 2) editable to the user are included. If ADMIN/ONC gets the CSV file then they do get all the original criteria because they can do pretty much whatever they want. [#OCD-4705]
[#OCD-4705]
kekey1
changed the title
Certification Status reviewer must be run regardless of the (updated) status of the listing. If the "Active" status is removed, the updated listing is no longer Active but validation should still be run as that may have been the only status. [#OCD-4705]
andlar
previously approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.