Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce AuthenticatedXrpcBlueskyApi convenience implementation #14

Merged
merged 2 commits into from
Dec 26, 2024

Conversation

christiandeange
Copy link
Owner

This implementation will transparently manage the active session and refresh tokens for that BlueskyApi instance as it interacts with session-related APIs.

cc @CanYumusak this should resolve #11 – let me know how it looks for you!

This implementation will transparently manage the active session and
refresh tokens for that BlueskyApi instance as it interacts with
session-related APIs.
@JayOhEn
Copy link

JayOhEn commented Dec 18, 2024

I was actually looking for something like this, will update my lib version once it's available. Thank you!

@Jon6193
Copy link

Jon6193 commented Dec 21, 2024

Can this be merged and released in a new version? I'm trying to avoid making these changes locally to use this new class for session management instead

@CanYumusak
Copy link

I'm not sure if @christiandeange is waiting for me, but I've given my approval. I won't be able to test it in-depth until after the holiday season but it generally looks good

@christiandeange
Copy link
Owner Author

I'm not sure if @christiandeange is waiting for me, but I've given my approval. I won't be able to test it in-depth until after the holiday season but it generally looks good

Just wanted to get external opinion(s) on the API design here. Thanks all! It'll be included in a new release shortly.

@christiandeange christiandeange merged commit 5fc7e8c into main Dec 26, 2024
5 checks passed
@christiandeange christiandeange deleted the chr/xrpc-auth-api branch December 26, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include mechanic similar to "XrpcAuthPlugin" in bluesky library
4 participants