Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of states/objects, reduced to only one set of balancing states, removed duplicates, fixed some units, added min and max Temp of towers #311

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

zloe
Copy link

@zloe zloe commented Aug 2, 2024

Cleanup of state/object definitions. (fixes #309)
Reduced to only one set of balancing states as they are anyhow stored per battery tower.
--> tested this only in a two tower setup!!!
Fixed/added some units.
Added min and max cell temp of towers.
Changed name/description of states/objects with statistical values (standard deviation, std-dev).

@christianh17 christianh17 self-assigned this Dec 21, 2024
@christianh17
Copy link
Owner

Dank der Hilfe aus dem developer telegram channel habe ich jetzt endlich wieder eine funktionierende Code-Basis die auch die checks von github besteht. Jetzt versuche ich Deinen PR zu mergen - wegen Änderungen die erst mal sein mussten lässt sich der Code nicht mehr automatisch mergen. Ich schaue mir das in Ruhe Zeile für Zeile an, hoffe bis zum neuen Jahr auch ein wenig Zeit dafür zu haben. Danke für Deine Vorschläge!

@christianh17
Copy link
Owner

Hi Zloe, the obvious errors are corrected, at least in the github version. But there are some changes which would create a problem with users who already use the states as they are. Can you please have a look at the new code? What do you think we can change without disturbing the working installations too much. Kind regards, Christian

@zloe
Copy link
Author

zloe commented Dec 24, 2024

Hi Christian,
I'll take a look.
In line 267 the myObjects Array there are a lot of duplicates, that shuold be cleaned up, this would not affect anything.
Regarding renamed states you could simply keep the "old" states for compatibility and add the new ones for the future.
Also the units are wrong for some states.
I will adjust my pull request later or create a new one. It might take some time.

  • Klaus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong name for Diagnosis.BatteryVolt and other mistakes in the object structure "Diagnosis"
2 participants