Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Multimodal example not working on colab #3917

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kylediaz
Copy link

@kylediaz kylediaz commented Mar 6, 2025

Description of changes

In your docs, you link to a ipynb demo in Google Colab. This demo won't work in Colab unless you pip install a few packages.

Also, when loading the dataset, you try to load a dataset called coco but it looks like the only one available is called default.

dataset = load_dataset(path="detection-datasets/coco", name="default"...)

I'm not sure how this error started occurring because this dataset hasn't changed since this example was created. Either way, it at least works in Colab now.

Test plan

Ran it in Colab with a fresh kernel

Copy link

github-actions bot commented Mar 6, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@kylediaz kylediaz force-pushed the kylediaz/multimodal-example-fix branch from 964b354 to 9403c7a Compare March 6, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant