[BUG]: correctly handle replays on local HNSW writer #3936
+62
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
codetheweb
requested review from
sanketkedia and
Sicheng-Pan
and removed request for
sanketkedia
Sicheng-Pan
reviewed
Mar 8, 2025
Comment on lines
+113
to
+127
| let current_seq_id = { | ||
| let (query, values) = Query::select() | ||
| .column(MaxSeqId::SeqId) | ||
| .from(MaxSeqId::Table) | ||
| .and_where( | ||
| Expr::col(MaxSeqId::SegmentId).eq(segment.id.to_string()), | ||
| ) | ||
| .build_sqlx(SqliteQueryBuilder); | ||
| let row = sqlx::query_with(&query, values) | ||
| .fetch_optional(sql_db.get_conn()) | ||
| .await?; | ||
| row.map(|row| row.try_get::<u64, _>(0)) | ||
| .transpose()? | ||
| .unwrap_or_default() | ||
| }; |
There was a problem hiding this comment.
nit: wrap this into a method for reuse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Found while working on the collection method proptest for Rust.
Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustAdded test fails on main for the Rust bindings.
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?
n/a