Use configured downloadsFolder for Cypress

[tevanoff]

Issue: #

What Changed

The Cypress integration was hardcoded to use Cypress's default value for downloadsFolder, cypress/downloads. Changes to that in the Cypress config would not be respected, and archive files would always be written to the default.

This fixes that by reading the correct value from the Cypress config object.

How to test

• Set downloadsFolder to a non-default value in cypress.config.ts
• Run Cypress tests, ensure Chromatic archives ouput in the directory set above, not in cypress/downloads
• Run a Chromatic build, ensure all is 💯

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.02% (target: -1.00%)	✅ 100.00% (target: 80.00%)

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (753f167)	259	245	94.59%
Head commit (a4cd9c4)	260 (+1)	246 (+1)	94.62% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#164)	2	2	100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

---

_{🚀 Don’t miss a bit, follow what’s new on Codacy.}

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

[andrewortwein]

⬇️🗂️ Changes look good to me 👍🏻

[skitterm]

Nice work @tevanoff! Glad that awkward ./cypress/downloads/some business I had written in is now gone.

[skitterm]

@tevanoff it seems like the directory traversal wouldn't be as much of a risk since people are configuring their own outputDir, which looks on "their" OS/container for files. Is it worth making this change to be totally safe, or is outputDir a relative path?

[andrewortwein]

@skitterm, Todd brought up that we don't currently have any unit tests that verify things are written to a configured outputDir. But we also don't have any tests covering the default case, so this could be a bit of a rabbit hole. Do you have any opinion on whether it's worth prolonging this fix to implement tests in this area?

[skitterm]

Do you have any opinion on whether it's worth prolonging this fix to implement tests in this area?

@andrewortwein @tevanoff my gut says that it's not worth the time to add the tests, where we didn't see an easy way of putting them in.

[skitterm]

A couple small questions, but I'm glad we're able to cover this with tests without too much hassle!

[skitterm]

Looks good!