Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin storybook dependency to <8.2 #179

Closed

Conversation

joshuajaco
Copy link
Contributor

@joshuajaco joshuajaco commented Jul 11, 2024

Quickfix for #180

The build-archive-storybook CLI does not work with [email protected].
This is because it assumes there is a top-level index.js file:

const binPath = resolve(dirname(require.resolve('storybook/package.json')), './index.js');

However, in storybook 8.2, I think the new path would be bin/index.cjs, see https://www.npmjs.com/package/storybook/v/8.2.0?activeTab=code

This PR ensures that only versions 8.1.0 < 8.2.0 will be used as a quick fix.

@joshuajaco joshuajaco force-pushed the pin-storybook-dependency branch from b471e0c to 957db6e Compare July 11, 2024 11:27
@joshuajaco
Copy link
Contributor Author

See #181 for a proper fix

@joshuajaco joshuajaco closed this Jul 13, 2024
@joshuajaco joshuajaco deleted the pin-storybook-dependency branch July 13, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant