Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: updated outdated data #385

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

tests: updated outdated data #385

wants to merge 2 commits into from

Conversation

bayram-dev
Copy link

@bayram-dev bayram-dev commented Jun 8, 2023 •
edited
Loading 

Results: TESTS/OK/FAILED 26/25/1
FAILED: [27] rust/:learn/

@bayram-dev
tests: updated outdated data
e0c771b 
Results: TESTS/OK/FAILED 24/24/0
bayram-dev
bayram-dev commented Jun 8, 2023
View reviewed changes
tests/tests.txt
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New checks: #381 (comment)

abitrolly
abitrolly reviewed Jun 8, 2023
View reviewed changes
tests/results/15
@@ -1,383 +1,388 @@
# Single line comments start with a number symbol.
# Single line comments start with a number symbol.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get why this started to fail when libs are not changed. GitHub already removed the logs, so need a manual bisect to check when these fails started.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess i found some reason why it was failing. Just tested on my fork. So

cheat.sh/tests/run-tests.sh

Line 109 in 571377f

test $failed -eq 0

If any of given tests fail - the build fails.
So, removed trailing slash test, but now docker fails

Copy link
Author

@bayram-dev bayram-dev Jun 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alpine 3.18 and specified pip packages works in Github Actions Ubuntu Tests

  • Only specified requirements.txt error to Levenshtein

  • Alpine 3.16 with requirements.txt error to ICU, but icu required packages (Installing icu-data-en (71.1-r2)) added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abitrolly abitrolly abitrolly left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bayram-dev @abitrolly