Make rfc.sh work on macos #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abitrolly
added a commit
that referenced
this pull request
Feb 1, 2025
abitrolly
reviewed
Feb 1, 2025
That's because MacOS uses Bash 3, and this syntax was from Bash 4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also for some reason when running
r./share/adapters/rfc.shpreviously, I was getting the following error.I don't know the reason why, but this PR fixes this problem as well.
Did not test it on linux so please do test.
So this PR accomplishes the following:
bad substitutionerror.rfc.shwork on macos as well, because of different verions ofsed. One being gnu's and the other one being bsd'sThanks.