-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for specifying HTTP and HTTPS bindings on IIS sites #39
Conversation
…port & certificate thumbprint
…irtual Directory's ApplicationPool + ManagedRuntimeVersion
…ngs must be recreated each time.
… bindings to a remote machine
…umbprints in test app.config for issue #6
…g. Completed CertificateStore tests. Issue #6
…f PathOnServer is not provided. Added a default.
…barfs if PathOnServer is not provided. Added a default.
…hat it barfs if PathOnServer is not provided. Added a default.
server.Iis7Site("default").Bindings(b => b.Add("http", 12000))
…etPath.GetPhysicalPath() and would fail on build servers. This fix still allows you to not specify a path for test fixtures.
… them up in the store.
… remote server when the local computer is x86 although it would work fine on x64. Found the hidden AddSslCertificate method which can be used instead.
Love that you have quite a few commits - would love to see the pull request from from a branch folder though...so when you move forward later we don't run into commit bleed. |
I'm pretty new to GitHub. Could you give me some tips on how you'd like to receive pull requests in the future? |
do the work for a pull request in a branch. Push the branch to github. Do the pull request from the branch. Make sense? |
Gotcha. You ok for these changes or would you like me to re-present them On 22 February 2012 17:32, Rob Reynolds <
|
I haven't had a chance to look at them yet... |
Hi Laazyj, I pulled down your repo and took a look. You have an awefully lot of work that I would hate to waste, and here is what you will want to do, to get everything going. I hope I have this correct. ;)
Note: I see you did a merge, we may have to do some surgery to fix that. |
I know that merge is going to cause some issues, if you get stuck give me a holler. |
Hey guys, has this made it any closer to making into chucknorris:master? I might be able to help if needed... |
Have a look at https://github.com/laazyj/dropkick/blob/master/product/dropkick.tests/TestObjects/IisHttpsSiteDeploy.cs for a look at how it works.
There are also some other changes related to IIS7 operations.
J