Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for specifying HTTP and HTTPS bindings on IIS sites #39

Closed
wants to merge 41 commits into from

Conversation

laazyj
Copy link
Contributor

@laazyj laazyj commented Feb 21, 2012

Have a look at https://github.com/laazyj/dropkick/blob/master/product/dropkick.tests/TestObjects/IisHttpsSiteDeploy.cs for a look at how it works.

There are also some other changes related to IIS7 operations.

J

…irtual Directory's ApplicationPool + ManagedRuntimeVersion
…f PathOnServer is not provided. Added a default.
…barfs if PathOnServer is not provided. Added a default.
…hat it barfs if PathOnServer is not provided. Added a default.
server.Iis7Site("default").Bindings(b => b.Add("http", 12000))
…etPath.GetPhysicalPath() and would fail on build servers. This fix still allows you to not specify a path for test fixtures.
… remote server when the local computer is x86 although it would work fine on x64. Found the hidden AddSslCertificate method which can be used instead.
@ferventcoder
Copy link
Member

Love that you have quite a few commits - would love to see the pull request from from a branch folder though...so when you move forward later we don't run into commit bleed.

@laazyj
Copy link
Contributor Author

laazyj commented Feb 22, 2012

I'm pretty new to GitHub. Could you give me some tips on how you'd like to receive pull requests in the future?

@ferventcoder
Copy link
Member

do the work for a pull request in a branch. Push the branch to github. Do the pull request from the branch. Make sense?

@laazyj
Copy link
Contributor Author

laazyj commented Feb 22, 2012

Gotcha. You ok for these changes or would you like me to re-present them
differently?

On 22 February 2012 17:32, Rob Reynolds <
[email protected]

wrote:

do the work for a pull request in a branch. Push the branch to github. Do
the pull request from the branch. Make sense?


Reply to this email directly or view it on GitHub:
#39 (comment)

@ferventcoder
Copy link
Member

I haven't had a chance to look at them yet...

@drusellers
Copy link
Member

Hi Laazyj,

I pulled down your repo and took a look. You have an awefully lot of work that I would hate to waste, and here is what you will want to do, to get everything going. I hope I have this correct. ;)

  1. git remote add chuck git://github.com/chucknorris/dropkick.git
  2. git rebase chuck/master
  3. fix any merge conflicts
  4. git checkout -b my_feature #now you have a feature branch
  5. Run tests
  6. fix tests
  7. make sure you are update date w/ us by running step 1 again.
  8. submit pull request.
  9. Smile :)

Note: I see you did a merge, we may have to do some surgery to fix that.

@drusellers drusellers closed this Mar 26, 2012
@drusellers
Copy link
Member

I know that merge is going to cause some issues, if you get stuck give me a holler.

@jcornell
Copy link

Hey guys, has this made it any closer to making into chucknorris:master? I might be able to help if needed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants