Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SERVER_NAME usage because could be localhost with reverse proxies #73

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yoyos
Copy link

@yoyos yoyos commented Jan 23, 2019

I had problem with localhost values for a long time now because I always used reverse proxies like nginx or today traefik

Check my tickets:
1 year, 6 months: https://wordpress.org/support/topic/ogurl-is-always-localhost/
A few days: https://wordpress.org/support/topic/ogurl-localhost-continuing/

I tested those changes and if home_url is correctly set in general settings, I had no problem displaying og:url on frontpage or everywhere else

@yoyos
Copy link
Author

yoyos commented Jan 23, 2019

I saw that I had multiple og:image with same image url that was causing errors with facebook debugger, changed that too.

@chuckreynolds
Copy link
Owner

Hey @yoyos I like the array unique; quick fix.
As for the local host values I'd have to test it and i don't have the time for local env setup and all the test scenarios.
I don't have an ETA on when I'd get to that but... this plugin is old... still functional but it needs a refactor pretty bad. I've had plans for that for a while but client work and life are priority.

That said with the image array I was going to have much different logic for that moving forward as FB linter has changed how they handle images drastically from how they used to when this version was released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants