add ALTER as sql statment, that is not returning anything (yihui#2330)

add ALTER as sql statment, that is not returning anything, so dbfetch shouldn't be used
chuxinyuan · Mar 4, 2024 · 031e08c · 031e08c
1 parent ad47ce5
commit 031e08c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/NEWS.md b/NEWS.md
@@ -32,6 +32,8 @@
 
 - Fixed broken vignettes, improved CSS for HTML vignettes, and reduced the file sizes.
 
+- SQL code chunks that run `ALTER` statements are only executed and not tried to fecth a result (thanks, @maxschmi, #2330).
+
 # CHANGES IN knitr VERSION 1.45
 
 ## NEW FEATURES

diff --git a/R/engine.R b/R/engine.R
@@ -558,7 +558,7 @@ is_sql_update_query = function(query) {
   query = gsub('^\\s*--.*\n', '', query)
   # remove multi-line comments
   if (grepl('^\\s*\\/\\*.*', query)) query = gsub('.*\\*\\/', '', query)
-  grepl('^\\s*(INSERT|UPDATE|DELETE|CREATE|DROP).*', query, ignore.case = TRUE)
+  grepl('^\\s*(INSERT|UPDATE|DELETE|CREATE|DROP|ALTER).*', query, ignore.case = TRUE)
 }
 
 # sql engine