fix yihui#2348: make hook_purl() return invisible NULL explicitly sin…

…ce write_utf8() now returns the file path
chuxinyuan · Jun 6, 2024 · 1db544b · 1db544b
1 parent f50b75b
commit 1db544b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: knitr
 Type: Package
 Title: A General-Purpose Package for Dynamic Report Generation in R
-Version: 1.47.2
+Version: 1.47.3
 Authors@R: c(
     person("Yihui", "Xie", role = c("aut", "cre"), email = "[email protected]", comment = c(ORCID = "0000-0003-0645-5666")),
     person("Abhraneel", "Sarma", role = "ctb"),

diff --git a/NEWS.md b/NEWS.md
@@ -4,6 +4,8 @@
 
 - Fix regression from 1.46 with `collapse = TRUE` option not correctly collapsing source code and output into one when code chunk returns multiple outputs (thanks, @jennybc, @florisvdh, tidyverse/reprex#463).
 
+- `hook_purl()` should not write the path of the R script to the output document (thanks, @fenguoerbian, #2348).
+
 # CHANGES IN knitr VERSION 1.47
 
 ## NEW FEATURES

diff --git a/R/hooks-extra.R b/R/hooks-extra.R
@@ -155,4 +155,5 @@ hook_purl = function(before, options, ...) {
     )
     write_utf8(code, output)
   }
+  invisible()
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -155,4 +155,5 @@ hook_purl = function(before, options, ...) { @@
         )
         write_utf8(code, output)
       }
+      invisible()
     }