Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ksmbd-tools: document duplicate key-value handling
The config parser has always ignored duplicate key-values. This may very well be surprising to users so document it. Let's also document how duplicate sections are handled, which conversely is typical, and improve some wording. Signed-off-by: Atte Heikkilä <[email protected]> Signed-off-by: Namjae Jeon <[email protected]>
- Loading branch information
b59d6f2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the commit message, it would have been better to say that the config parser has always intended to ignore duplicate ("multiple") key-values. The intention was clearly there at 2.0.1, but the functionality was broken until commit e5396bd.
This is now a documented incompatibility with Samba's
smb.conf
. If compatibility is desired, then this behavior should be changed before this documentation reaches users. I will not be contributing that change. This behavior of ignoring duplicate key-values is at least consistent with the other config parser oddities. For example, the long-standing bug at namjaejeon#197 (comment), which was fixed (in a Samba incompatible way) in commit 75ec1bc.b59d6f2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@atheik Okay, Should we add the description to next release note for this ?
b59d6f2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@namjaejeon,
Description about what? The fix to the long-standing bug?
b59d6f2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@atheik No, Do we need to add description for about incompatibility with Samba's smb.conf ?
b59d6f2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@namjaejeon,
What change to
smb.conf
compatibility was there?