-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link to Cilium community teams repo, re-organize the order #46
Conversation
9411840
to
64cb6aa
Compare
For cilium/cilium there is also CODEOWNERS which can help provide some more hints - for instance someone might not know which of the dozens of teams to contact, what the scope of those teams is, or which files they're responsible for. This could help to clarify some of these questions: https://github.com/cilium/cilium/blob/main/CODEOWNERS |
Signed-off-by: xtine <[email protected]>
Signed-off-by: xtine <[email protected]>
17655b6
to
20b9929
Compare
README.md
Outdated
|
||
Many design docs also begin their life as a Google doc or other shareable | ||
file for easy commenting and editing when still in the early stages of discussion. | ||
Once your proposal is done, submit it as a PR to the design-cfps folder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once your proposal is done, submit it as a PR to the design-cfps folder. | |
Once your proposal is ready, submit it as a PR to the design-cfps folder for the project it is for. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, there aren't any designated folders, they are just all under the cilium
folder. That would be nice to have dedicated folders, but also for CFPs that touch multiple facets of the project, would this be the best layout?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking that each project would have its own folder. It just hasn't happened yet since there haven't been CfPs for hubble or tetragon yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah gotcha - in that case, until the folders are made, i think we should keep it as is, make the change to the wording once they are present?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can just add the folders in this PR too?
Signed-off-by: xtine <[email protected]>
Signed-off-by: xtine <[email protected]>
Signed-off-by: xtine <[email protected]>
Related to #45, but adding in link to Cilium Community Teams so folks know who to ping on SIG related topics