Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to Cilium community teams repo, re-organize the order #46

Merged
merged 5 commits into from
Aug 2, 2024

Conversation

xtineskim
Copy link
Contributor

Related to #45, but adding in link to Cilium Community Teams so folks know who to ping on SIG related topics

@joestringer
Copy link
Member

joestringer commented Jul 17, 2024

For cilium/cilium there is also CODEOWNERS which can help provide some more hints - for instance someone might not know which of the dozens of teams to contact, what the scope of those teams is, or which files they're responsible for. This could help to clarify some of these questions: https://github.com/cilium/cilium/blob/main/CODEOWNERS

README.md Outdated

Many design docs also begin their life as a Google doc or other shareable
file for easy commenting and editing when still in the early stages of discussion.
Once your proposal is done, submit it as a PR to the design-cfps folder.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Once your proposal is done, submit it as a PR to the design-cfps folder.
Once your proposal is ready, submit it as a PR to the design-cfps folder for the project it is for.

Copy link
Contributor Author

@xtineskim xtineskim Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, there aren't any designated folders, they are just all under the cilium folder. That would be nice to have dedicated folders, but also for CFPs that touch multiple facets of the project, would this be the best layout?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking that each project would have its own folder. It just hasn't happened yet since there haven't been CfPs for hubble or tetragon yet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah gotcha - in that case, until the folders are made, i think we should keep it as is, make the change to the wording once they are present?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can just add the folders in this PR too?

@xmulligan xmulligan merged commit 563f2ee into cilium:main Aug 2, 2024
1 check passed
@xmulligan xmulligan mentioned this pull request Aug 2, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants