Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shared_client: Bump request id #12

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

shared_client: Bump request id #12

wants to merge 6 commits into from

Commits on Apr 30, 2024

  1. shared_client: Try new id if already in use 

    Only fail out if non-conflicting request id can not be found in couple of
tries.

This works on the premise that the callers are fine with the request id
being modified at this point. Current use sets a random id just prior to
Exchange call, so this premise is satisfied.

Signed-off-by: Jarno Rajahalme <[email protected]>
    @jrajahalme
    jrajahalme committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    fe97f44 View commit details
    Browse the repository at this point in the history

  2. shared_client: Buffer responses channel 

    Buffer responses channel so that the handler does not get blocked of the
channel is not received from (e.g., after a timeout).

Signed-off-by: Jarno Rajahalme <[email protected]>
    @jrajahalme
    jrajahalme committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    022c597 View commit details
    Browse the repository at this point in the history

  3. shared_client: Use configured timeout also for response 

    Use the configured read timeout to bound the time spent on receiving the
response, instead of waiting for a full minute.

Signed-off-by: Jarno Rajahalme <[email protected]>
    @jrajahalme
    jrajahalme committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    f027334 View commit details
    Browse the repository at this point in the history

  4. shared_client: Drain requests on handler close 

    Drain requests on handler close, so that pending requests are terminated
immediately when handler needs to close for an error condition, rather
than having the requests time out. This allows the handler to be recycled
faster for new requests.

Signed-off-by: Jarno Rajahalme <[email protected]>
    @jrajahalme
    jrajahalme committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    75c2156 View commit details
    Browse the repository at this point in the history

  5. GH: Bump tested Go versions to v1.18 & v1.19 

    container/heap uses `any`, which was added in Go 1.18. Bump tested Go
versions to accomodate for this.

Signed-off-by: Jarno Rajahalme <[email protected]>
    @jrajahalme
    jrajahalme committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    67f6b75 View commit details
    Browse the repository at this point in the history

  6. shared_client: Clean up waiters after timeouts 

    Tell handler to delete waiters after request times out.

Signed-off-by: Jarno Rajahalme <[email protected]>
    @jrajahalme
    jrajahalme committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    5724e90 View commit details
    Browse the repository at this point in the history