ci: add test run with race detector #1674
Open
+41
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcacheux
force-pushed
the
race-tests
branch
2 times, most recently
from
1e9c8d8 to
36a9355
Compare
Signed-off-by: Paul Cacheux <[email protected]>
ti-mo
approved these changes
Feb 26, 2025
Signed-off-by: Timo Beckers <[email protected]>
|
Looks like running with the race detector enabled crashes the GH runner (?). The logs aren't showing, but they did stream in when I started the job, and RoundtripVMLinux was the last test it was able to start. Locally, this works fine, but there may be some additional constraints on these runners. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1673, this PR adds a test run with the race detector enabled.
In the thread it was discussed to re-use the "previous go version" run and to add
-raceto it, but it's not possible because the race detector requires CGo, this makes the test binary not static anymore, and vimto is having a hard time running it.This PR choses the easy path and just creates a new test run closer to the arm64 one (no vimto)