script: Revert buggy change to grep command #25
Merged
+28
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pippolo84
approved these changes
Nov 15, 2024
The stdout and stderr commands already existed, and my change to grep to allow searching stdout was buggy, so revert this. Signed-off-by: Jussi Maki <[email protected]>
'help aoeu' panic due to not checking whether the cmd was found before calling Usage() Signed-off-by: Jussi Maki <[email protected]>
joamaki
force-pushed
the
pr/joamaki/revert-grep-change
branch
from
55dbd56 to
2cd8786
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stdout and stderr commands already existed, and my change to grep to allow searching stdout was buggy, so revert this.
The second commit fixes a panic on "help some-unknown-command" (cilium/cilium#35918)