Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action: Handle hyphen in image version #359

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

kevsecurity
Copy link
Contributor

The regex that chops an image version into its name and version assumes there is only one hyphen and that separate the name from the version. The "bpf-next" images break this assumption. This commit changes the regex to handle hyphens in the image name.

@kevsecurity kevsecurity marked this pull request as ready for review January 28, 2025 13:33
@kevsecurity kevsecurity requested a review from kkourt January 28, 2025 13:33
The regex that chops an image version into its name and version assumes
there is only one hyphen and that separate the name from the version.
The "bpf-next" images break this assumption. This commit changes the
regex to handle hyphens in the image name.

Signed-off-by: Kevin Sheldrake <[email protected]>
@kevsecurity kevsecurity force-pushed the pr/kevsecurity/handle-hyphen-in-image-version branch from 1cf5608 to 0f6692a Compare January 28, 2025 15:16
@kevsecurity kevsecurity merged commit 61a6dac into main Jan 28, 2025
2 checks passed
@kevsecurity kevsecurity deleted the pr/kevsecurity/handle-hyphen-in-image-version branch January 28, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

action.yaml: regression in image-name derivation (bpf-next, bpf-net, ...)
2 participants