Add GHA workflows to build and lint the cmapisrv-mock #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giorio94
force-pushed
the
pr/giorio94/github-workflows
branch
6 times, most recently
from
129e845 to
f100dff
Compare
Addressed the following two deprecation warnings reported by golangci-lint: WARN [config_reader] The configuration option `linters.staticcheck.go` is deprecated, please use global `run.go`. WARN [lintersdb] The name "goerr113" is deprecated. The linter has been renamed to: err113. Signed-off-by: Marco Iorio <[email protected]>
Apparently, these two vendored files do originally use CRLF line ending, but got committed using the LF line ending. This causes the new lint workflow to fail due to the difference introduced when running go mod vendor. Let's fix this by committing them with the CRLF line ending. Signed-off-by: Marco Iorio <[email protected]>
Signed-off-by: Marco Iorio <[email protected]>
As they need to be executed independently of whether a file with the same name already exists or not. Signed-off-by: Marco Iorio <[email protected]>
Currently, the cmapisrv-mock does not include unit tests, hence this is effectively a no-op. Yet, if added, they should be run in a separate workflow, to not impact the image build task. Signed-off-by: Marco Iorio <[email protected]>
giorio94
force-pushed
the
pr/giorio94/github-workflows
branch
from
f100dff to
22da222
Compare
aanm
requested changes
Jun 26, 2024
Signed-off-by: Marco Iorio <[email protected]>
Signed-off-by: Marco Iorio <[email protected]>
giorio94
force-pushed
the
pr/giorio94/github-workflows
branch
from
22da222 to
320ec5a
Compare
|
Successful run with image push: https://github.com/cilium/scaffolding/actions/runs/9681290574/job/26711523516?pr=85 |
giorio94
force-pushed
the
pr/giorio94/github-workflows
branch
from
320ec5a to
a0f6a86
Compare
aanm
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.