Added paste image support #167
Open
+720
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
9 tasks
|
I have read the CLA Document and I hereby sign the CLA |
|
When will it be merged? Are there any blockers? |
hugeblank
added a commit
to hugeblank/cinny-desktop
that referenced
this pull request
Sep 26, 2023
Does what title says. Lifts event handler logic from paste image support (cinnyapp#167). Includes some commented out logic for compatibility with systray (cinnyapp#166) when/if merged. Requires TRAY_LABEL be exposed as public, however.
hugeblank
added a commit
to hugeblank/cinny-desktop
that referenced
this pull request
Sep 26, 2023
Does what title says. Lifts event handler logic from paste image support (cinnyapp#167). Includes some commented out logic for compatibility with systray (cinnyapp#166) when/if merged. Requires TRAY_LABEL be exposed as public, however.
9 tasks
|
Any update? |
|
Structure of Cinny app changed some time ago, this patch no longer works, it should roughly translate into this now: ED: wrong repo, this should be applied to https://github.com/cinnyapp/cinny/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces support to paste images. It utilizes the
arboardcrate to fetch image data from the clipboard, then provides it as a base64 encoded string to the frontend using a Tauri command.This PR depends on cinnyapp/cinny#1238
Fixes #69
Tested on Ubuntu 22.04 LTS on Wayland.
Type of change
Checklist: