-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement system theme (dark mode) and fix background image on windows. #792
base: master
Are you sure you want to change the base?
Conversation
it was creating a white box around the image while in system dark mode, so I substituted it by lowering the image opacity to 70% the old image and .xcf file are safe to remove but preserved
I may be wrong, but there's probably a qt property you can read that tells you if it's dark mode? @ctrleo |
I feel like the image blends too well with the text, so I'm gonna lower the opacity a little more |
I think it might be better to just remove the background image entirely in dark mode. Let me know your opinion. |
@axu2 its kinda cute tho :( I'm trying to think of a way we might be able to pop a grey tint over it during dark mode which would make the letters stand out more |
Maybe make the image grayscale or black and white, maybe invert the colors on top, etc |
thats an intuitive solution but it would be a challenge since it's difficult to change the image itself since it's compiled in with the ui files. I thought about putting a low opacity grey border around the text to help it stand out, which looks like this: @axu2 lmk what you think and i'll push the commit |
a little more progress the reason the current logo looks the way it does is because of a white cast filter over the image which essentially blends it with the background, however, when system dark mode is activated, gives us this: (For reference, the text does display the correct colours, but there's a bug which causes it to default to one of the two colours in a sceenshot) |
This is getting there, but I want it to look like the example in the QT link earlier: e.g. the text box has a white background in light mode, etc. currently the text box has the same background color as the window. And you could probably make the logo even more transparent. I can look into this later, this command may help (or just search for string "fusion"):
Also, thanks for pointing out I broke the cropping power slider orientation at some point. I'll look into that, it should be horizontal. like in 7.00 and earlier. |
@axu2 gm! I looked into fusion and found that, with WIndows, it really takes that odd little accent colour feature and runs with it, see below: Imo I feel like it just makes it look unnecessarily tacky, however, I'm gonna change the opacity of the logo again then I'll figure out how to brighten/darken the job list box compared to background. |
I added back the background color property in on light mode it doesnt make much difference on a low brightness, I also added opacity to the background-color attribute, because the background-image tends to get stuck behind it on windows |
This pr implements feature request #741
Changes
Removedbackground
(color) property fromlist_background
, which allows the app to use the system default colour insteadbackground-color
inlist_background
, which alternate depending on themelist_background.png
and replicated the effect by lowering the image opacity to70%10%list_background.png
and it's GIMP editor file tolist_background_old.png
andlist_background_old.xcf
Created a subroutine inshared.py
to detect if system is in dark mode or notQApplication.styleHints().colorScheme()
KCC_7.0.0.spec
, a file generated throughsetup.py build_binary
on windows, to .gitignoreThis fixes...
Screenshots
Windows
Before
After
After (in light mode)
Linux (on Debian XFCE with Dracula theme)
Before
After
Ty for considering my contribution! ^-^