Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Teams testplans that test policy 4.1 (test plan variants e# and gcc) #1559

Conversation

nanda-katikaneni
Copy link
Collaborator

@nanda-katikaneni nanda-katikaneni commented Feb 7, 2025

🗣 Description

This PR updates Teams test plan variants that test policy 4.1. Recent changes to the Set-CsTeamsClientConfiguration require an additional input parameter. The two appropriate test plans have been updated to add an additional pre-condtion to pass the 'identity' parameter.

💭 Motivation and context

Closes #1545

🧪 Testing

  • Run the Teams functional test plan for the variant e# using a E5/E3 tenant
  • Ensure that test plans run without errors and correctly pass/fail the tests

📷 Screenshots (if appropriate)

Ran the e# and gcc variant teams test plans on appropriate tenants and both compliant and non-complaint test cases passed.
Screenshot 2025-02-07 at 11 34 54 AM
Screenshot 2025-02-07 at 11 37 52 AM

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • These code changes follow the ScubaGear content style guide.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant type-of-change labels added.
  • All relevant project fields are set.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • Unit tests added/updated to cover PowerShell and Rego changes.
  • Functional tests added/updated to cover PowerShell and Rego changes.
  • All relevant functional tests passed.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

  • PR passed smoke test check.

  • Feature branch has been rebased against changes from parent branch, as needed

    Use Rebase branch button below or use this reference to rebase from the command line.

  • Resolved all merge conflicts on branch

  • Notified merge coordinator that PR is ready for merge via comment mention

  • Demonstrate changes to the team for questions and comments.
    (Note: Only required for issues of size Medium or larger)

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@nanda-katikaneni nanda-katikaneni self-assigned this Feb 7, 2025
@nanda-katikaneni nanda-katikaneni added bug This issue or pull request addresses broken functionality Testing This issue or task involves testing the automation tool function labels Feb 7, 2025
@nanda-katikaneni nanda-katikaneni added this to the Lionfish milestone Feb 7, 2025
@nanda-katikaneni nanda-katikaneni removed the request for review from james-garriss February 7, 2025 17:17
Copy link
Collaborator

@schrolla schrolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran Teams functional tests using updated test plan against all four test tenants using either the e# or gcc plan as approrpriate for the given tenant. All worked and passed. Also reverted MicrosoftTeams library to oldest allowable by SG (4.9.3) and the test plan still worked properly so the new parameter has been present for some time and only change was it became mandatory. So no breakage when backtesting.
Good update, looks good to go to me.

@nanda-katikaneni nanda-katikaneni requested review from ahuynhMITRE and dagarwal-mitre and removed request for dagarwal-mitre February 7, 2025 18:00
Copy link
Collaborator

@ahuynhMITRE ahuynhMITRE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no issues to report with running the functional test plan for Teams. No other comments from me!

@nanda-katikaneni nanda-katikaneni merged commit 76840a8 into main Feb 7, 2025
23 checks passed
@nanda-katikaneni nanda-katikaneni deleted the 1545-teams-functional-test-for-policy-41-is-failing-for-both-compliant-and-non-complaint-cases branch February 7, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality Testing This issue or task involves testing the automation tool function
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Teams functional test for policy 4.1 is failing for both compliant and non-complaint cases
3 participants