#1604 allow analysts to view cancelled invitations - [AD]

[asaki222]

Ticket

Resolves #1604

Changes

• Removed all instances of DomainInvitationDelete references, and replacing them with the new DomainInvitationCancel
• Adding two new transition methods(updating the status from invited to cancel, and cancel to invited)
• Updated test from DomainInvitationDelete

Context for reviewers

Steps Test

1. Add a new domain manager to a domain
2. Cancel the domain invitation on the view. The domain invitation should drop from the view
3. The domain invitation should appear on the domain invitation table on admin as canceled.
4. If you invite the same email to the same domain, it will still send an email, and update the table status to "Invited"
5. If you export a csv of the domains, the domain invitations with cancelled status, should not appear on the csv.

Code Review Verification Steps

As the original developer, I have

Satisfied acceptance criteria and met development standards

• Met the acceptance criteria, or will meet them in a subsequent PR
• Created/modified automated tests
• Update documentation in READMEs and/or onboarding guide

Ensured code standards are met (Original Developer)

• If any updated dependencies on Pipfile, also update dependencies in requirements.txt.
• Interactions with external systems are wrapped in try/except
• Error handling exists for unusual or missing values

Validated user-facing changes (if applicable)

• Tag @dotgov-designers in this PR's Reviewers for design review. If code is not user-facing, delete design reviewer checklist
• Verify new pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
• Checked keyboard navigability
• Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)

As a code reviewer, I have

Reviewed, tested, and left feedback about the changes

• Pulled this branch locally and tested it
• Verified code meets all checks above. Address any checks that are not satisfied
• Reviewed this code and left comments. Indicate if comments must be addressed before code is merged
• Checked that all code is adequately covered by tests
• Verify migrations are valid and do not conflict with existing migrations

Validated user-facing changes as a developer

Note: Multiple code reviewers can share the checklists above, a second reviewer should not make a duplicate checklist. All checks should be checked before approving, even those labeled N/A.

• New pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
• Checked keyboard navigability
• Meets all designs and user flows provided by design/product
• Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
• (Rarely needed) Tested as both an analyst and applicant user

As a designer reviewer, I have

Verified that the changes match the design intention

• Checked that the design translated visually
• Checked behavior. Comment any found issues or broken flows.
• Checked different states (empty, one, some, error)
• Checked for landmarks, page heading structure, and links

Validated user-facing changes as a designer

• Checked keyboard navigability
• Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
• Tested with multiple browsers (check off which ones were used)
  • Chrome
  • Microsoft Edge
  • FireFox
  • Safari
• (Rarely needed) Tested as both an analyst and applicant user

References

• Code review best practices

Screenshots

[github-actions]

🥳 Successfully deployed to developer sandbox ad.

[github-actions]

🥳 Successfully deployed to developer sandbox ad.

[github-actions]

🥳 Successfully deployed to developer sandbox ad.

[github-actions]

🥳 Successfully deployed to developer sandbox ad.

[github-actions]

🥳 Successfully deployed to developer sandbox ad.

[github-actions]

🥳 Successfully deployed to developer sandbox ad.

[github-actions]

🥳 Successfully deployed to developer sandbox ad.

[Matt-Spence]

Is this a change in our coding practices? What's the justification for no longer inheriting from DomainInvitationPermission{Delete/Cancel}View?

[asaki222]

I just removed it from this text since DomainInvitationPermissionDeleteView no longer exists. I will add DomainInvitationPermissionCancelView! This is a great catch.

[github-actions]

🥳 Successfully deployed to developer sandbox ad.

[github-actions]

🥳 Successfully deployed to developer sandbox ad.

[github-actions]

🥳 Successfully deployed to developer sandbox ad.

[Matt-Spence]

Great work.