Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug in maker-cli show-fidelity rpc call #436

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

VanshulB
Copy link

@VanshulB VanshulB commented Mar 5, 2025

fixes #430

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 70.92%. Comparing base (b9b3ff2) to head (6cdf13d).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/wallet/fidelity.rs 0.00% 10 Missing ⚠️
src/maker/rpc/messages.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #436      +/-   ##
==========================================
+ Coverage   70.88%   70.92%   +0.04%     
==========================================
  Files          32       32              
  Lines        4272     4279       +7     
==========================================
+ Hits         3028     3035       +7     
  Misses       1244     1244              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@mojoX911 mojoX911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@mojoX911 mojoX911 merged commit 1052735 into citadel-tech:master Mar 5, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bugs in maker-cli show-fidelity rpc call
2 participants